Added IMAP Microsoft Graph Configs#2610
Open
antt1995 wants to merge 5 commits intosameersbn:masterfrom
Open
Conversation
Contributor
Author
Contributor
Author
|
@kkimurak |
kkimurak
suggested changes
Jul 21, 2022
Contributor
kkimurak
left a comment
kkimurak
left a comment
There was a problem hiding this comment.
Thank you for your prompt contribution. It looks good to functionally but I have some suggestions in addition to individual reviews:
- Naming for configuration parameter are too simple.
For example,IMAP_TENANT_IDwill become a value forgitlab::incoming_email::inbox_options::tenant_idin gitlab.yml. Therefore, I think a name likeGITLAB_INCOMING_EMAIL_INBOX_OPTIONS_TENANT_IDis easier to associate with the key name in yaml (it should also be useful for anyone reading the official gitlab documentation and trying to use thissameersbn/gitlab).
Yes, I know that other parameters related to IMAP have such simple names (likeIMAP_HOST). So feel free to ignore me. If I lose patience with it, I will submit a pull request to unify the naming conventions (of course, it is entirely possible that the maintainer will reject it, and there is nothing wrong with that). - (optional)
inbox_options::poll_intervalis missing. - (optional) It is nice if we can support
inbox_options::azure_ad_endpointandinbox_options::graph_endpointfor Microsoft Cloud as well.
Sorry for the nagging review. Please let me know if it seems difficult or if I am being cryptic. I will send you a patch.
Co-authored-by: Kazunori Kimura <33391846+kkimurak@users.noreply.github.com>
Co-authored-by: Kazunori Kimura <33391846+kkimurak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.