Suggest struct pattern when destructuring Range with .. syntax #149952
+117
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
Contributor
Author
|
r? @Alexendoo |
Member
|
I'm not part of the compiler team so I'll pass it back over to r? @lcnr |
| err.span_suggestion_verbose( | ||
| pat.span, | ||
| "if you meant to destructure a `Range`, use the struct pattern", | ||
| format!("std::ops::Range {{ start: {}, end: {} }}", start_name, end_name), |
Contributor
There was a problem hiding this comment.
It'd be helpful if this suggested std::range::Range/core::range::Range when #![feature(new_range)] is enabled (might not be necessary since new_range is still unstable).
Contributor
Author
There was a problem hiding this comment.
Regarding new_range: I'm sticking with std::ops::Range for now since it's the stable default, but we can revisit that once the feature stabilizes.
|
|
||
| err.span_suggestion_verbose( | ||
| pat.span, | ||
| "if you meant to destructure a `Range`, use the struct pattern", |
Contributor
There was a problem hiding this comment.
Nit:
Suggested change
| "if you meant to destructure a `Range`, use the struct pattern", | |
| "if you meant to destructure a `Range`, use a struct pattern", |
Contributor
Author
There was a problem hiding this comment.
I've updated the message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented a new diagnostic in rustc_resolve to detect invalid range destructuring attempts (e.g., let start..end = range). The fix identifies when resolution fails for identifiers acting as range bounds specifically handling cases where bounds are parsed as expressions and suggests the correct struct pattern syntax (std::ops::Range { start, end }). This replaces confusing "cannot find value" errors with actionable help, verified by a new UI test covering various identifier names.
Fixes #149777