Cleanup of attribute parsing errors #149949
Open
+288
−308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
jdonszelmann
requested changes
Dec 13, 2025
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
JonathanBrouwer
force-pushed
the
error_cleanup
branch
from
ee2bc6b to
17649b5
Compare
Contributor
Author
|
@rustbot ready @jdonszelmann Good idea, I improved a bunch of the spans :) |
rustbot
added
S-waiting-on-review
| | | | ||
| | expected this to be a list | ||
| | | ||
| = note: for more information, visit <https://doc.rust-lang.org/reference/items/external-blocks.html#the-link-attribute> |
Contributor
There was a problem hiding this comment.
hm we don't give any actual usage examples here 🤔
Contributor
Author
There was a problem hiding this comment.
That is because of #149917
#[link] has too many examples so it decides not to show any.
I'm currently actually working on improving this system, this PR is the first in a series. I want to give more contextual usage examples.
Lets fix this in a future PR
jdonszelmann
requested changes
Dec 13, 2025
rustbot
added
S-waiting-on-author
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors r- |
bors
added
S-waiting-on-author
JonathanBrouwer
force-pushed
the
error_cleanup
branch
from
17649b5 to
ae39d3d
Compare
Contributor
Author
|
@bors r=jdonszelmann rollup |
Collaborator
bors
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 13, 2025
…donszelmann Cleanup of attribute parsing errors Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors. Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name r? `@jdonszelmann`
bors
added a commit
that referenced
this pull request
Dec 13, 2025
…uwer Rollup of 5 pull requests Successful merges: - #148755 (Constify `DropGuard::dismiss` and trait impls) - #148825 (Add SystemTime::{MIN, MAX}) - #149894 (Update to mdbook 0.5) - #149930 (std: small `sys` refactor) - #149949 (Cleanup of attribute parsing errors) r? `@ghost` `@rustbot` modify labels: rollup
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 13, 2025
…donszelmann Cleanup of attribute parsing errors Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors. Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name r? ``@jdonszelmann``
bors
added a commit
that referenced
this pull request
Dec 13, 2025
…uwer Rollup of 5 pull requests Successful merges: - #148755 (Constify `DropGuard::dismiss` and trait impls) - #148825 (Add SystemTime::{MIN, MAX}) - #149894 (Update to mdbook 0.5) - #149949 (Cleanup of attribute parsing errors) - #149955 (Fix typo in armv7a-vex-v5 documentation) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 14, 2025
…uwer Rollup of 5 pull requests Successful merges: - #148755 (Constify `DropGuard::dismiss` and trait impls) - #148825 (Add SystemTime::{MIN, MAX}) - #149894 (Update to mdbook 0.5) - #149949 (Cleanup of attribute parsing errors) - #149955 (Fix typo in armv7a-vex-v5 documentation) r? `@ghost` `@rustbot` modify labels: rollup
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Dec 14, 2025
…donszelmann Cleanup of attribute parsing errors Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors. Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name r? ```@jdonszelmann```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the specific
UnknownMetaItemandIllFormedAttributeInputLinterrors.Note that
IllFormedAttributeInputLintis not a lint, contrary to its namer? @jdonszelmann