Add new disallowed_fields lint
#16218
Open
+239
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
needs-fcp
S-waiting-on-review
GuillaumeGomez
force-pushed
the
disallowed_fields
branch
from
48e76b6 to
73d1c63
Compare
GuillaumeGomez
commented
Dec 11, 2025
| // Very round-about way to get the field `DefId` from the expr: first we get its | ||
| // parent `Ty`. Then we go through all its fields to find the one with the expected | ||
| // name and get the `DefId` from it. | ||
| if let Some(parent_ty) = cx.typeck_results().expr_ty_opt(e) |
Member
Author
There was a problem hiding this comment.
I'm really not sure this is the best way to get the DefId from Expr::Field but couldn't find another way. I'd love to know if there is one!
Contributor
There was a problem hiding this comment.
This needs to use the adjusted type.
antoyo
reviewed
Dec 11, 2025
GuillaumeGomez
commented
Dec 11, 2025
| .filter_by_name_unhygienic(name) | ||
| .find(|assoc_item| ns.matches(Some(assoc_item.namespace()))) | ||
| .map(|assoc_item| assoc_item.def_id), | ||
| ItemKind::Struct(_, _, rustc_hir::VariantData::Struct { fields, .. }) => fields.iter().find_map(|field| { |
Member
Author
There was a problem hiding this comment.
Basically added support to look for fields in lookup_path (above in this file). it's used to check if the paths are valid in the config file.
So to link to a field (for example with struct X { y: u8 }: X::y.
GuillaumeGomez
force-pushed
the
disallowed_fields
branch
from
73d1c63 to
eacd758
Compare
GuillaumeGomez
force-pushed
the
disallowed_fields
branch
from
eacd758 to
d017b2c
Compare
Member
Author
|
Finally updated all things that needed to be updated. :') |
Contributor
|
This doesn't prevent reading via destructuring. e.g. |
Member
|
r? @Jarcho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9278.
This is something that we need for
cg_gcc(cc @antoyo). It's almost the same as #6674 (which I used as base).changelog: Add new
disallowed_fieldslintr? @samueltardieu