-
Notifications
You must be signed in to change notification settings - Fork 683
Create new Svelte project #12487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Turbo87
wants to merge
13
commits into
rust-lang:main
Choose a base branch
from
Turbo87:svelte-basics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create new Svelte project #12487
+1,174
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d402fd to
dcbc33d
Compare
b487af7 to
64cfbb4
Compare
``` pnpm dlx sv create --template minimal --types ts --add prettier eslint vitest="usages:unit,component" --install pnpm svelte ```
This should make the migration a bit easier for now. We can go back to SSR rendering in the future once SPA mode works sufficiently well.
The Svelte app is using an inline script in the HTML file which includes the fingerprinted JS file paths, so we can't use a static hash of the script. We can figure these details out in the future.
Not sure where this is suddenly coming from, but we can just use different variable names instead to fix it.
ef339a8 to
8830a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-backend ⚙️
A-frontend 🐹
C-enhancement ✨
Category: Adding new behavior or a change to the way an existing feature works
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last crates.io team meeting we decided to explore Svelte 5 as a replacement for our Ember.js frontend.
We evaluated a variety of options including SSR via Rust (and e.g. minijinja) and came to the conclusion that Svelte is currently our least bad option, mostly for DX reasons due to our tiny team size.
This PR:
svelte/directory/svelte/sveltejob to the GitHub Actions workflow, that runs when anything in the Svelte app is changed.This allows us to build the Svelte app incrementally alongside the Ember.js app without needing an unreviewable big bang release. Once the new app is on par with the old one we can switch over to it.