Don't set CMAKE_SYSTEM_NAME when using the Visual Studio generator #193
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-signal
commented
Nov 13, 2023
src/lib.rs
Outdated
Comment on lines
460
to
464
| && !(msvc | ||
| && self | ||
| .generator | ||
| .as_deref() | ||
| .map_or(true, |g| g.to_string_lossy().starts_with("Visual Studio"))) |
Author
There was a problem hiding this comment.
This is definitely weirdly complicated for an inline condition, and depends on the default generator choice for MSVC being Visual Studio (implemented below, unchanged). Suggestions welcome on how to reorganize this.
Author
|
(Test failures are also happening on upstream.) |
tgross35
added
the
S-waiting-on-review
Setting CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR is often enough for CMake to handle cross-compilation even without a toolchain file, but it gets in the way of generators that handle cross-compilation on their own (in Visual Studio's case, using the -T "toolset" option).
jrose-signal
force-pushed
the
visual-studio-cross-compilation
branch
from
88ba56f to
897845f
Compare
ChrisDenton
reviewed
Dec 13, 2025
Member
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
On the face of it this does look reasonable to me. We shouldn't have competing sources of truth for cross-compiling.
However, I'm not yet familiar enough with how this crate is used in practice to be confident this won't be breaking for someone out there. Could someone be relying on CMAKE_SYSTEM_NAME or CMAKE_SYSTEM_PROCESSOR being set even for Visual Studio builds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
CMAKE_SYSTEM_NAMEandCMAKE_SYSTEM_PROCESSORis often enough for CMake to handle cross-compilation even without a toolchain file, but it gets in the way of generators that handle cross-compilation on their own (in Visual Studio's case, using the -T "toolset" option).Narrow fix for the issue I brought up in #158 (comment). Possible fix for #171 as well, if it does turn out to be the same thing.