-
Notifications
You must be signed in to change notification settings - Fork 117
Add example for CLI tests with temporary directories and setting the current working directory (CWD) #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
|
||
| </aside> | ||
|
|
||
| ## Executing tests in a temporary directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all focusing on teaching an API and is not fitting it within the narrative of the book
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rewrite the section intro to fit better with the style of the section before and after.
For example, by connecting the newly introduced APIs to what the book has explored so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also needs to be tied into the application we are testing
|
Thanks for the review. Update: I split the unrelated changes into a separate commit, and combined the main changes into a single commit. Will think about how to get the example to fit better with the book's narrative. |
3fe28f9 to
26b2faf
Compare
test with a specific current working directory (CWD). This expands on the basic examples and ensures the common needs for CLI app testing are covered. Hopefully, this will make testing more accessible to people reading the book.
Main changes
Describe how to create temporary directories, and how to execute the CLI test with a specific current working directory (CWD).
This expands on the basic examples and ensures the common needs for CLI app testing are covered. Hopefully, this will make testing more accessible to people reading the book.