fix: missing example in psbt segwit example#35
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jan 5, 2025
Merged
Conversation
Member
|
Thanks for the contribution! This made me wonder why it wasn't caught by CI. The reason is that the rustdoc block patched is imports only. I believe the import block should mirror the one right at the bottom. Furthermore I think they should both be improved to be like this: use std::collections::BTreeMap;
use std::str::FromStr;
use bitcoin::bip32::{ChildNumber, Fingerprint, IntoDerivationPath as _, Xpriv, Xpub};
use bitcoin::hashes::Hash;
use bitcoin::locktime::absolute;
use bitcoin::secp256k1::{Secp256k1, Signing};
use bitcoin::{
consensus, psbt, transaction, Address, Amount, EcdsaSighashType, Network, OutPoint, Psbt,
ScriptBuf, Sequence, Transaction, TxIn, TxOut, Txid, WPubkeyHash, Witness,
};Note that this requires changing all instances of |
Contributor
Author
|
Sure, that makes sense. I applied the changes you suggested 8a0bf08 |
Member
|
You forgot to squash the |
8a0bf08 to
b369269
Compare
Contributor
Author
Done. |
tcharding
approved these changes
Jan 4, 2025
Member
|
Killed it, thanks bro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example
cookbook/src/psbt/multiple_inputs_segwit-v0.mdhad some missing imports and some unnecessary ones.