Skip to content

Worked on issue #700#747

Merged
jmilljr24 merged 11 commits intorubyforgood:mainfrom
Abhiishekk31:main
Jan 29, 2026
Merged

Worked on issue #700#747
jmilljr24 merged 11 commits intorubyforgood:mainfrom
Abhiishekk31:main

Conversation

@Abhiishekk31
Copy link
Contributor

@Abhiishekk31 Abhiishekk31 commented Jan 21, 2026

@Abhiishekk31
Copy link
Contributor Author

_ No description provided. _

@maebeale Please check into it. I hope it can be merged now.

Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhiishekk31 Looks like you committed some extra files again but otherwise it's looking good!

You can keep the same PR, just remove schema.rb .env.example and package-lock.json

A new commit reverting them is fine or edit your previous commit and force push the change to this PR without those files.

@Abhiishekk31
Copy link
Contributor Author

@jmilljr24 removed those three extra files that you asked for.

@jmilljr24
Copy link
Collaborator

jmilljr24 commented Jan 23, 2026

@Abhiishekk31 Ah, so the way you did it will completely remove them from our repo if I accept and merge this. Not sure if github has a UI option but locally you need to do something like:

# reset a file back to main
git checkout origin/main -- path/to/file
git commit -m "Revert file from PR"
git push

Basically taking the version from the main branch and putting it into your working branch. It's fine if you keep pushing up commits to try things. No worries.

@Abhiishekk31 Abhiishekk31 marked this pull request as draft January 23, 2026 15:08
@Abhiishekk31 Abhiishekk31 marked this pull request as ready for review January 23, 2026 15:08
Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing those extra files that shouldn't have changes in this PR.

@Abhiishekk31
Copy link
Contributor Author

I'm still seeing those extra files that shouldn't have changes in this PR.

-- those three files are present in the codebase, I just reconfigured them to their default settings.

-- I think those were the instructions.

-- I am still unclear on what to do right now , please guide

@jmilljr24
Copy link
Collaborator

I'm still seeing those extra files that shouldn't have changes in this PR.

-- those three files are present in the codebase, I just reconfigured them to their default settings.

-- I think those were the instructions.

-- I am still unclear on what to do right now , please guide

Ah, I see why my last comment didn't work for you. You've made commits to the main branch on your fork. People generally create a working branch for their changes and keep their fork's main branch the same code as the project's code.

Here is the alternative:

This restores specific files from the real repo’s main branch directly into your fork’s main branch.

  1. Make sure you’re on your fork’s main branch

    git checkout main

  2. Fetch the latest changes from upstream

    git fetch upstream

  3. Restore the files from upstream/main
    (this overwrites your local versions of these files)

    git checkout upstream/main -- db/schema.rb .env.sample package-lock.json

  4. Commit the reverted files

    git status
    git commit -m "Revert schema, env sample, and lockfile from upstream main"

  5. Push the fix to your fork

    git push origin main

@Abhiishekk31 Abhiishekk31 marked this pull request as draft January 28, 2026 09:21
@Abhiishekk31 Abhiishekk31 marked this pull request as ready for review January 28, 2026 09:21
Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhiishekk31 Almost there! After you make the changes but before committing and pushing can you run the rubocop linter.

From the command line, with the current directory being the project run:
rubocop -a

This should hopefully autocorrect any issues. This is required to pass our CI checks on github.

Contributing Guide

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you were successful reverting the other two files. Try that again with this one, along with the other changes I'm requesting.

@Abhiishekk31
Copy link
Contributor Author

I think I have done the neccessary

Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhiishekk31 Just need to fix the before_action and run rubocop -a as it still has linting errors.

@Abhiishekk31
Copy link
Contributor Author

ran rubocop -a and also updated the user_controller.rb file

Copy link
Collaborator

@jmilljr24 jmilljr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhiishekk31 Awesome! Thank you

@jmilljr24 jmilljr24 merged commit c03059d into rubyforgood:main Jan 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants