Merged
Conversation
…rd_path The before block was clicking through the avatar dropdown to reach the change password page, but the flash message overlay sometimes blocked the avatar button. Since the tests are about the change password page behavior (not avatar dropdown navigation), visit the path directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset_password_person_spec.rbtest that intermittently failed withUnable to find css "#avatar button"beforeblock was navigating to the change password page by clicking through the avatar dropdown, but the#flash_nowcontainer div is always present in the DOM, so the flash-dismiss wait was ineffective and the flash overlay sometimes blocked the avatar buttonvisit change_password_path, since the tests are about change password page behavior, not avatar dropdown navigationFixes #826
Test plan
reset_password_person_spec.rbpasses in CI🤖 Generated with Claude Code