Conversation
Owner
|
We need to make the three state approach work has all the latest logic I will publish depends on this.
|
Collaborator
Author
Yes, I understand, but the implementation might be different. Go ahead with your work we can discuss on Sunday. Note This PR has nothing to do with the bigger pictures. It is adding a test case and removing the use of :toggle since that does not work as expected. |
rswgnu
requested changes
Jan 11, 2026
ChangeLog
Outdated
| 2026-01-07 Mats Lidell <matsl@gnu.org> | ||
|
|
||
| * hywiki.el (hywiki-mode): Remove arg value :toggle, not an alternative to | ||
| 'toogle. |
rswgnu
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add test for hywiki-mode. Also remove the :toggle argument value.
Why
Adding more line coverage and noticed a problem while doing
that. Hence a small PR that only focus on the issue.
The :toggle parameter value does not do what you would
expect. define-minor-mode does the change of the minor-mode variable
but does not recognize :toggle.
Notes
Maybe using one minor mode for three states is not the best idea after
all. Toggling twice from :pages state active leads to :all state
active.
It seems define-minor-mode and define-global-minor-mode uses a pattern
that we could benefit from.
Lets look into this again.