Skip to content

fix: remove @rspack/dev-server from rspack overrides#18

Merged
9aoy merged 1 commit intomainfrom
rspack-dev-server
Mar 19, 2026
Merged

fix: remove @rspack/dev-server from rspack overrides#18
9aoy merged 1 commit intomainfrom
rspack-dev-server

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Mar 19, 2026

fix rspack-ecosystem-ci: remove @rspack/dev-server from rspack overrides.

image

https://github.com/web-infra-dev/rspack/actions/runs/23284556227/job/67705584021

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue impacting the rspack-ecosystem-ci by refining the package override settings. The change specifically targets the rspack-package.json file to remove an unnecessary or problematic entry for @rspack/dev-server, thereby stabilizing the continuous integration process.

Highlights

  • Configuration Update: Removed the @rspack/dev-server entry from the rspack overrides configuration within rspack-package.json.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @rspack/dev-server package from the packages list in rspack-package.json. According to the description, this is a fix for a CI failure. The change is a simple deletion in a JSON configuration file and appears correct and consistent with the stated intent. I have reviewed the changes and found no issues.

@9aoy 9aoy merged commit 916bf27 into main Mar 19, 2026
23 of 33 checks passed
@9aoy 9aoy deleted the rspack-dev-server branch March 19, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant