test: add imports field chain resolution test cases#178
test: add imports field chain resolution test cases#178stormslowly wants to merge 7 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the test suite for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds two test cases for imports field resolution. One test for chained imports is expected to fail as the feature is not yet supported, which is a good approach. The other test for resolving to a bare specifier seems correct. I have one minor suggestion for consistency.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78d5915b69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds additional regression tests around imports field resolution behavior in the resolver test suite, focusing on “chained” # imports and imports that map to a bare specifier.
Changes:
- Add
test_imports_chainintended to cover chainedimportsmappings (#a -> #b -> ./the.js). - Add
test_imports_chain_to_other_packageto coverimportsmapping to a bare package specifier (#c -> c).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…s/rspack-resolver into chore/add_import_chain_test_case
…s/rspack-resolver into chore/add_import_chain_test_case
…s/rspack-resolver into chore/add_import_chain_test_case
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Summary
Add two test cases for
importsfield resolution, which will be used for regression testing in other RP.test_imports_chain(currently ignored)Chained imports resolution:
#a→#b→./the.js{ "imports": { "#a": "#b", "#b": "./the.js" } }the.jsERR_MODULE_NOT_FOUND— treats#bas a bare package specifierMODULE_NOT_FOUND— same reasonNotFound("#b")— chain resolution not yet supportedThe problem is that the error message is confusing; it tells user
#bnot defined, but it's shown inimports.test_imports_chain_to_other_packageImports resolving to a bare specifier:
#c→"c"→node_modules/c/index.js{ "imports": { "#c": "c" } }node_modules/c/index.jsnode_modules/c/index.jsnode_modules/c/index.jsnode_modules/c/index.jsTest plan
cargo test test_imports_chain_to_other_packagepassescargo test test_imports_chaincurrently fails (expected — chain resolution not yet supported)