[ntuple] Add ctx manager to RNTupleReader and update RNTupleWriter's#21131
Merged
silverweed merged 1 commit intoroot-project:masterfrom Feb 26, 2026
Merged
Conversation
silverweed
requested review from
guitargeek,
jblomer and
vepadulano
as code owners
Test Results 22 files 22 suites 3d 11h 30m 53s ⏱️ For more details on these failures, see this check. Results for commit f3d5b2e. ♻️ This comment has been updated with latest results. |
2 tasks
vepadulano
reviewed
Feb 4, 2026
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rntuple.py
Outdated
Show resolved
Hide resolved
silverweed
force-pushed
the
rntuplereader_close_py
branch
2 times, most recently
from
a9b7af0 to
b1b0ce6
Compare
jblomer
reviewed
Feb 12, 2026
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
LGTM but should be approved by @vepadulano or @guitargeek
vepadulano
requested changes
Feb 12, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thanks! A few more questions/comments
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rntuple.py
Outdated
Show resolved
Hide resolved
silverweed
force-pushed
the
rntuplereader_close_py
branch
from
b1b0ce6 to
b5f20f8
Compare
Now both the Reader and Writer's context objects will close the underlying file upon __exit__. The object will raise an exception if accessed after the `with` statement.
silverweed
force-pushed
the
rntuplereader_close_py
branch
from
eada079 to
f3d5b2e
Compare
vepadulano
approved these changes
Feb 24, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thank you! LGTM once tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now both the Reader and Writer's context objects will close the underlying file upon
__exit__. The object will raise an exception if accessed after thewithstatement.Checklist: