Skip to content

Conversation

@x12301450
Copy link

Remove the trailing slash of ROOT_LLVM_MAIN_SRC_DIR in CMakeLists.txt.

This PR fixes is #21093

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Test Results

    22 files      22 suites   3d 17h 44m 3s ⏱️
 3 776 tests  3 775 ✅ 0 💤 1 ❌
75 992 runs  75 991 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 4c62a81.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a path formatting issue in the CMake configuration by removing a trailing slash from the ROOT_LLVM_MAIN_SRC_DIR variable definition. This prevents the creation of malformed paths with double slashes when the variable is concatenated with other path components that begin with a leading slash.

Changes:

  • Removed trailing slash from ROOT_LLVM_MAIN_SRC_DIR path definition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guitargeek
Copy link
Contributor

I'm curious: what's the benefit of this change? Can CMake not deal with double slashes? Normally that doesn't make the path invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants