[ntuple] Allow for late-model extension in untyped records #21088
+419
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
force-pushed
the
ntuple-extend-untyped-record
branch
2 times, most recently
from
1b30888 to
4a38381
Compare
Let MakeField() call AddField() internally.
Test Results 22 files 22 suites 3d 16h 17m 48s ⏱️ For more details on these failures, see this check. Results for commit ff82b89. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Feb 2, 2026
Remove the assumption in the serialization code that extended field hierarchies are always rooted in the zero field.
Clarification on deferred columns and extended fields.
jblomer
force-pushed
the
ntuple-extend-untyped-record
branch
from
4a38381 to
ff82b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19957