[tmva][sofie] arguments check to avoid mismatches with dynamic parameters#21073
Open
sanjibansg wants to merge 2 commits intoroot-project:masterfrom
Open
[tmva][sofie] arguments check to avoid mismatches with dynamic parameters#21073sanjibansg wants to merge 2 commits intoroot-project:masterfrom
sanjibansg wants to merge 2 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 13h 28m 57s ⏱️ Results for commit 55cc5b5. ♻️ This comment has been updated with latest results. |
dpiparo
requested changes
Jan 29, 2026
Member
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
Besides the failing tests, could you please follow the contribution guide here https://github.com/root-project/root/blob/master/CONTRIBUTING.md ? This applies also to the commit message.
sanjibansg
force-pushed
the
sofie/rmodel/arg_check
branch
2 times, most recently
from
08047a4 to
8866d12
Compare
…ters When SOFIE is used to infer models with dynamic parameters, it is essential to check if they are in the allowed range. Otherwise this may cause an overflow and subsequently a segmentation fault. This check verifies is the passed parameters is lesser or equal to their limits set during instantion of the Session object, otherwise throws a runtime error.
sanjibansg
force-pushed
the
sofie/rmodel/arg_check
branch
from
8866d12 to
1d4f203
Compare
lmoneta
reviewed
Jan 30, 2026
… for dynamic parameters
sanjibansg
force-pushed
the
sofie/rmodel/arg_check
branch
from
194b73d to
55cc5b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements checks on the arguments of the infer method to avoid any mismatches with the dynamic parameters.
When SOFIE is used to infer models with dynamic parameters, it is essential to check if they are in the allowed range. Otherwise this may cause an overflow and subsequently a segmentation fault. This check verifies is the passed
parameters is lesser or equal to their limits set during instantion of the Session object, otherwise throws a runtime error.