-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple] Add RPageSinkFile::CloneWithDifferentName #21063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 22 files 22 suites 3d 9h 22m 25s ⏱️ For more details on these failures, see this check. Results for commit c8e2b81. ♻️ This comment has been updated with latest results. |
b2d8186 to
d1b6b48
Compare
Do we also need to support the case where the user would like to clone in a different directory (and/or is it mostly for internal use)? |
It's for internal use only (for the Attributes) and we always want to write to the same directory |
d1b6b48 to
88f3c3a
Compare
fa2b7b6 to
53d06d8
Compare
Writing analogue to RPageSourceFile::OpenWithDifferentAnchor, it allows to derive a new Sink from an existing one using the same underlying directory but writing to a different RNTuple.
53d06d8 to
c8e2b81
Compare
Last part of #19904.
Adds a writing analogue to RPageSourceFile::OpenWithDifferentAnchor, which allows to derive a new Sink from an existing one using the same underlying directory but writing to a different RNTuple.
Was previously called
DeriveForbut I found the name too obscure and I think this is clearer.Checklist: