Skip to content

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Dec 18, 2025

this makes sure we don't fix a portion of the code but still have some other place that's broken


Summary by cubic

Deduplicates the render pipeline and unifies stream decoding across environments, fixing multi‑byte character issues and making error handling consistent. This reduces repeated code in browser, edge, and node paths.

  • Refactors

    • Introduced shared renderToReadableStream and used it in browser, edge, and node where supported.
    • Unified stream reading with a streaming TextDecoder; simplified Node readStream to PipeableStream only.
    • Added browser read-stream tests and updated existing tests.
    • tsconfig now includes node and vitest/globals types; added @types/node dev dependency.
  • Bug Fixes

    • Correctly decodes multi-byte characters (CJK, emoji) split across chunks.
    • Improved Node render error propagation by handling onShellError.

Written for commit 2139b56. Summary will update automatically on new commits.

@gabrielmfern gabrielmfern requested review from a team and bukinoshita and removed request for a team December 18, 2025 14:45
@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

⚠️ No Changeset found

Latest commit: 2139b56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
react-email Ready Ready Preview, Comment Dec 18, 2025 2:45pm
react-email-demo Ready Ready Preview, Comment Dec 18, 2025 2:45pm

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​types/​node@​24.9.1 ⏵ 25.0.31001008196 +2100

View full report

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/@react-email/render@2750

commit: 2139b56

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants