Document container setup for OCaml and dune#7899
Document container setup for OCaml and dune#7899cristianoc wants to merge 1 commit intoreturn-marker-flagsfrom
Conversation
|
@codex: do make test |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| let test_rewrite_loses_return_flag _ctx = | ||
| let source = "let f = x => g(x)\n" in | ||
| let structure = parse_structure source in | ||
| let body = extract_fun_body structure in | ||
| OUnit.assert_bool "pre-rewrite body should be marked" | ||
| (Res_return_marker.expression_is_return body); | ||
| let rewritten = Ppx_entry.rewrite_implementation structure in | ||
| let rewritten_body = extract_fun_body rewritten in | ||
| OUnit.assert_bool "rewritten body currently loses its return flag" | ||
| (not (Res_return_marker.expression_is_return rewritten_body)) |
There was a problem hiding this comment.
[P1] Invert return-flag assertion after rewriting
The new test_rewrite_loses_return_flag intentionally asserts that Ppx_entry.rewrite_implementation drops the return marker (assert_bool … (not (Res_return_marker.expression_is_return rewritten_body))). Tests should encode the desired behaviour, i.e. the flag should be preserved after rewriting. As written, the suite now passes only when the bug exists and will fail once the bug is fixed, which both masks the regression and locks the incorrect behaviour in place.
Useful? React with 👍 / 👎.
|
Summary
Testing
|
| make format && make checkformat | ||
| ``` | ||
|
|
||
| ## Container Tooling Setup |
There was a problem hiding this comment.
We also have our dev container setup (for working in a container in VS Code) at https://github.com/rescript-lang/rescript/tree/master/.devcontainer.
Do we actually need two different Docker setups?
If so, then it would be great to have a Dockerfile for this one, too, so that the agent just needs to run docker build in the correct directory.
|
I did not get this to go very far. Even instructing to install opam via apt-get, it always gets to the point where some fetch is blocked:
|
2 participants
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cb775741a0833193e0e6246b9b4b75