Fix dep_updates for v1 recipes using python_min by janjagusch · Pull Request #5306 · regro/cf-scripts

janjagusch · 2025-12-29T12:48:20Z

Summary

Fix the dep_updates migrator failing for v1 recipes that use python_min (CFEP-25).

Root cause: Grayskull generates skip: match(python, "<3.10") for noarch recipes, but v1 recipe variant configs only define python_min, not python. When rattler-build tries to render the recipe, all variants are skipped because python is undefined.

Fix: Replace match(python, with match(python_min, in grayskull-generated v1 recipes before rendering.

Changes

Add workaround in _make_grayskull_recipe_v1 to replace match(python, with match(python_min,
Add integration test case for dominodatalab feedstock
Add unit test test_get_grayskull_comparison_v1_python_min_mismatch
Add assert_pr_body_not_contains helper method for integration tests

Test Evidence

Successful version update PR created by the bot during integration testing:
janjagusch-conda-forge-bot-staging/dominodatalab-feedstock#28

This test case reproduces the issue where the dep_updates migrator fails for v1 recipes when grayskull generates a recipe with `skip: match(python, ...)` but the feedstock's variant config only has `python_min` (not `python`). The test adds: - dominodatalab feedstock as a git submodule (pinned to v1.4.7) - Test case that validates version update from 1.4.7 to 2.0.0 - New `assert_pr_body_not_contains` helper method to check PR body - Assertion that the PR body doesn't contain the dep_updates error message The test currently fails, demonstrating the bug where rattler-build skips all variants when the `python` variable is not in the variant config. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

This test reproduces the issue where get_grayskull_comparison fails for v1 recipes when grayskull generates `skip: match(python, "<3.10")` but the variant config only has `python_min` (not `python`). The test is marked as xfail since it currently fails - rattler-build skips all variants when the `python` variable is not set in the variant config. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

The xfail marker was causing pytest to consider the failing test as "passing" (expected failure). Removing it ensures the test actually fails in CI until the bug is fixed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replace `match(python, ...)` with `match(python_min, ...)` in grayskull-generated v1 recipes. This fixes the dep_updates migrator for feedstocks using CFEP-25's python_min variable. Grayskull generates skip conditions like `skip: match(python, "<3.10")` but v1 recipe variant configs only define `python_min`, not `python`. This caused rattler-build to skip all variants with: "Failed to render recipe YAML! No output recipes found!" See: conda/grayskull#574 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Add mock endpoint for version-specific PyPI API (/pypi/dominodatalab/2.0.0/json) - Include 'urls' field in main PyPI endpoint for grayskull sdist discovery - Add spdx.org/* to transparent URLs (grayskull license discovery) - Store full PyPI metadata response for reproducible testing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add documentation to help Claude Code understand the codebase structure, common commands, and integration test setup. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

beckermr · 2025-12-29T16:30:15Z

@wolfv rattler build should define python, right? Is this an issue somewhere in rattler-build or smithy maybe?

…egration-test # Conflicts: # .gitmodules

CLAUDE.md

conda_forge_tick/update_deps.py

Guard the match(python, ...) to match(python_min, ...) replacement with a check for package_is_noarch to avoid unintended changes to arch-specific recipes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Rename CLAUDE.md to AGENTS.md and create symlink for backwards compat - Make content agent-agnostic (remove Claude Code-specific references) - Remove "(recommended for development)" from environment.yml option - Use local conda-lock.yml instead of wget from GitHub - Remove unmaintained test feedstocks list Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

janjagusch · 2026-01-31T12:16:56Z

@beckermr, @ytausch, took me a bit to get back to it, but it should be ready for another round of reviews now. :)

codecov · 2026-01-31T12:34:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.69%. Comparing base (11e4141) to head (a1d8343).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5306      +/-   ##
==========================================
+ Coverage   80.66%   80.69%   +0.03%     
==========================================
  Files         144      144              
  Lines       16968    16976       +8     
==========================================
+ Hits        13687    13699      +12     
+ Misses       3281     3277       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

conda_forge_tick/update_deps.py

beckermr · 2026-01-31T13:00:41Z

This error looks odd?

tests/test_update_deps.py::test_get_grayskull_comparison_v1_python_min_mismatch - RuntimeError: Failed to render recipe YAML! No output recipes found!
[]

beckermr · 2026-01-31T13:01:29Z

/relock-conda

conda_forge_tick/update_deps.py

janjagusch · 2026-02-01T12:38:35Z

@beckermr, I was able to track the bug down to CRM and propose a fix: conda/conda-recipe-manager#480

The inline comment in our code now references the correct upstream issue: conda/conda-recipe-manager#479

My suggestion would be to merge the current version of the branch and remove the fix once we have a new release of CRM.

beckermr · 2026-02-01T15:11:25Z

did you run the integration tests locally? they are not running in CI because you are working from a fork.

My suggestion is to remove them or for you to ensure they work locally.

ytausch · 2026-02-02T09:28:26Z

I think the integration tests really add value here, so I'd go with option 2.

janjagusch · 2026-02-03T07:39:01Z

did you run the integration tests locally? they are not running in CI because you are working from a fork.

My suggestion is to remove them or for you to ensure they work locally.

The integration tests are still failing on my local machine. It's probably just a problem with the MITM proxy. I'll check today.

ytausch · 2026-02-03T07:57:22Z

@beckermr alternatively, we could also check if the merge queue passes, right?

beckermr · 2026-02-03T11:27:38Z

Yes let's try the queue. I did not want to debug the tests via the queue which is why I asked.

janjagusch · 2026-02-04T08:27:16Z

Thanks for merging, @beckermr. I will test the new version against conda-forge/dominodatalab-feedstock#23.

janjagusch · 2026-02-04T08:55:19Z

Worked like a charm: conda-forge/dominodatalab-feedstock#24 🚀

janjagusch and others added 4 commits December 29, 2025 13:37

janjagusch changed the title ~~Add failing tests for dominodatalab dep_updates issue~~ Fix dep_updates for v1 recipes using python_min Dec 29, 2025

janjagusch marked this pull request as draft December 29, 2025 14:55

janjagusch force-pushed the add-dominodatalab-integration-test branch from 12a2004 to 09ca7cc Compare December 29, 2025 16:21

docs: add CLAUDE.md for Claude Code guidance

5d9b386

Add documentation to help Claude Code understand the codebase structure, common commands, and integration test setup. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

janjagusch marked this pull request as ready for review December 29, 2025 16:23

ytausch self-requested a review January 19, 2026 17:19

Merge remote-tracking branch 'origin/main' into add-dominodatalab-int…

f672537

…egration-test # Conflicts: # .gitmodules

ytausch approved these changes Jan 19, 2026

View reviewed changes

CLAUDE.md Show resolved Hide resolved

CLAUDE.md Outdated Show resolved Hide resolved

CLAUDE.md Outdated Show resolved Hide resolved

CLAUDE.md Outdated Show resolved Hide resolved

beckermr requested changes Jan 19, 2026

View reviewed changes

conda_forge_tick/update_deps.py Outdated Show resolved Hide resolved

janjagusch and others added 4 commits January 31, 2026 13:10

Only apply python_min replacement for noarch recipes

2883823

Guard the match(python, ...) to match(python_min, ...) replacement with a check for package_is_noarch to avoid unintended changes to arch-specific recipes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Always use lockfile

c746b18

Merge branch 'main' into add-dominodatalab-integration-test

5a19be5

janjagusch requested review from beckermr and ytausch January 31, 2026 12:16

beckermr reviewed Jan 31, 2026

View reviewed changes

conda_forge_tick/update_deps.py Outdated Show resolved Hide resolved

beckermr reviewed Jan 31, 2026

View reviewed changes

conda_forge_tick/update_deps.py Show resolved Hide resolved

Apply suggestion from @beckermr

74c24a4

Update grayskull version to 3.1.0

40dbc97

beckermr reviewed Jan 31, 2026

View reviewed changes

conda_forge_tick/update_deps.py Outdated Show resolved Hide resolved

janjagusch mentioned this pull request Feb 1, 2026

fix: use python_min in skip conditions for noarch Python recipes conda/conda-recipe-manager#480

Open

3 tasks

janjagusch requested a review from beckermr February 1, 2026 12:38

Merge branch 'main' into add-dominodatalab-integration-test

4f8bde7

beckermr approved these changes Feb 1, 2026

View reviewed changes

ytausch approved these changes Feb 2, 2026

View reviewed changes

beckermr added this pull request to the merge queue Feb 3, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026

Merge branch 'main' into add-dominodatalab-integration-test

1128516

beckermr enabled auto-merge February 3, 2026 11:57

beckermr disabled auto-merge February 3, 2026 11:59

beckermr enabled auto-merge February 3, 2026 11:59

beckermr disabled auto-merge February 3, 2026 12:15

Merge branch 'main' into add-dominodatalab-integration-test

d033395

beckermr enabled auto-merge February 3, 2026 13:31

beckermr disabled auto-merge February 3, 2026 13:38

Merge branch 'main' into add-dominodatalab-integration-test

9d39599

beckermr enabled auto-merge February 3, 2026 18:14

Merge branch 'main' into add-dominodatalab-integration-test

a1d8343

beckermr added this pull request to the merge queue Feb 3, 2026

Merged via the queue into regro:main with commit cdf7d3a Feb 3, 2026
32 of 42 checks passed

h-vetinari mentioned this pull request Feb 6, 2026

Tests are failing due to interaction with grayskull #5514

Closed

Comments

Conversation

janjagusch commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test Evidence

Related

Uh oh!

beckermr commented Dec 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janjagusch commented Jan 31, 2026

Uh oh!

codecov bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

beckermr commented Jan 31, 2026

Uh oh!

beckermr commented Jan 31, 2026

Uh oh!

Uh oh!

janjagusch commented Feb 1, 2026

Uh oh!

beckermr commented Feb 1, 2026

Uh oh!

ytausch commented Feb 2, 2026

Uh oh!

janjagusch commented Feb 3, 2026

Uh oh!

ytausch commented Feb 3, 2026

Uh oh!

beckermr commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

janjagusch commented Feb 4, 2026

Uh oh!

janjagusch commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

janjagusch commented Dec 29, 2025 •

edited

Loading

codecov bot commented Jan 31, 2026 •

edited

Loading