Skip to content

ENG-8858: Docs follow ups#1759

Merged
Alek99 merged 3 commits intomainfrom
carlos/toc-extras
Feb 23, 2026
Merged

ENG-8858: Docs follow ups#1759
Alek99 merged 3 commits intomainfrom
carlos/toc-extras

Conversation

@carlosabadia
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Feb 20, 2026

ENG-8858 Docs follow ups

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 20, 2026

Greptile Summary

Enhanced documentation page UI with new table of contents sidebar features and improved styling.

Key changes:

  • Added markdown icon for new "Copy to markdown" functionality
  • Updated hero text color for better visual consistency
  • Refactored feedback forms to use standardized ui components instead of custom-styled elements
  • Added three new buttons to TOC sidebar: "Send feedback", "Copy to markdown", and "Ask AI about this page"
  • Modified get_toc() function to return both headings and document content (breaking change handled with backward compatibility logic)
  • Updated icon naming from kebab-case to PascalCase for consistency with UI library

The changes improve code maintainability by reducing custom styling and enhance user experience with additional documentation features.

Confidence Score: 5/5

  • Safe to merge - well-structured refactoring with backward compatibility
  • The PR contains straightforward UI improvements and refactoring. The potentially breaking change to get_toc() return type is handled with proper backward compatibility logic that checks tuple structure. All changes are localized and follow existing patterns in the codebase.
  • No files require special attention

Important Files Changed

Filename Overview
pcweb/components/icons/icons.py added markdown icon SVG definition to ICONS dictionary
pcweb/pages/docs_landing/views/hero.py updated text color from text-m-slate-10 to text-primary-10 for "About Reflex" label
pcweb/templates/docpage/docpage.py refactored feedback UI to use ui components, added TOC sidebar buttons (feedback, copy to markdown, ask AI), modified get_toc() to return tuple with doc content

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User visits doc page] --> B[docpage wrapper called]
    B --> C[contents function executed]
    C --> D{Is result a tuple?}
    D -->|No| E[Render component directly]
    D -->|Yes, len=2| F{Is first element a tuple?}
    F -->|Yes, len=2| G[Unpack: toc, doc_content from first<br/>comp from second]
    F -->|No - Legacy format| H[Unpack: toc from first<br/>comp from second]
    G --> I[Render TOC sidebar with new buttons]
    H --> J[Render TOC sidebar without doc buttons]
    I --> K[Show feedback_button_toc]
    I --> L[Show copy_to_markdown if doc_content exists]
    I --> M[Show ask_ai_chat]
    K --> N[User can send feedback]
    L --> O[User can copy markdown]
    M --> P[User navigates to AI chat]
Loading

Last reviewed commit: dc0e35a

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Alek99 Alek99 self-requested a review February 23, 2026 19:14
@Alek99 Alek99 merged commit 8efdae2 into main Feb 23, 2026
9 of 10 checks passed
@Alek99 Alek99 deleted the carlos/toc-extras branch February 23, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants