Merged
Conversation
- Change time units from ms to us for CPU time fields - Add SlotRange interface for slot range representation - Update field names (byCpuTime → byCpuTimeUs, etc.) - Fix HOTKEYS_STOP to return null in empty state - Update response parsing for new array-wrapped format - Add test for HOTKEYS_STOP empty state behavior - nil -> null
…l clients HOTKEYS commands require session affinity (sticky connection to a single Redis node) which cluster, pool, and sentinel clients cannot guarantee. Changes: - Created NON_STICKY_COMMANDS export in commands/index.ts that excludes HOTKEYS commands - Updated cluster, pool, and sentinel to use NON_STICKY_COMMANDS instead of COMMANDS - Added tests to verify HOTKEYS commands are not available on these client types
PavelPashov
reviewed
Feb 10, 2026
| break; | ||
| case 'sampled-command-selected-slots-us': | ||
| case 'sampled-commands-selected-slots-us': | ||
| result.sampledCommandSelectedSlotsUs = Number(value); |
Contributor
There was a problem hiding this comment.
Should we update the field in the response to sampledCommandsSelectedSlotsUs as well?
Collaborator
Author
There was a problem hiding this comment.
totally, i thought i updated it...
- Fix field name from 'sampled-command-selected-slots-us' to 'sampled-commands-selected-slots-us' (with 's') to align with server changes in the new test image - Update TypeScript property name from sampledCommandSelectedSlotsUs to sampledCommandsSelectedSlotsUs for consistency - Add comprehensive tests for all HOTKEYS GET response fields - Add cluster tests for SLOTS and SAMPLE options to verify slot-specific and sampled fields are correctly parsed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpass with this change (including linting)?