Skip to content

fix: double onchange and render double number pointer in input when i…#275

Open
405go wants to merge 2 commits intoreact-component:masterfrom
405go:master
Open

fix: double onchange and render double number pointer in input when i…#275
405go wants to merge 2 commits intoreact-component:masterfrom
405go:master

Conversation

@405go
Copy link

@405go 405go commented Nov 6, 2020

repro steps:

  1. visit https://ant.design/components/input-number-cn/
  2. switch to Chinese input method
  3. selected any input and type full stop...then you can see it has double pointer.

…nput first render use chinese input method and input full stop
@vercel
Copy link

vercel bot commented Nov 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/ocwejydkv
✅ Preview: https://input-number-git-master.react-component.vercel.app

.trim()
.replace(/。/g, '.')
.replace(/\.+/g, '.');

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能合成一个吗

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i got it

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.01%. Comparing base (5d29b67) to head (c583bda).
⚠️ Report is 191 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files           1        1           
  Lines         372      372           
  Branches      134      134           
=======================================
  Hits          346      346           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants