CMakeLists: Export the module targets. Document the changes #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleanup the code that creates the module targets - Rename the module targets to sqlpp23::xxxxx_module - When exporting module targets also export additional information that allows the targets to be imported.
MeanSquaredError
changed the title
MeanSquaredError
force-pushed
the
fix_module_install_4
branch
from
d63ffd6 to
dd9f6b7
Compare
MeanSquaredError
force-pushed
the
fix_module_install_4
branch
from
dd9f6b7 to
11b4326
Compare
Contributor
Author
|
Fixed a typo in the documentation: specifix -> specific |
rbock
reviewed
Jan 9, 2026
docs/setup.md
Outdated
| | sqlpp23::sqlite3 | #include <sqlpp23/sqlite3/sqlite3.h> | The SQLite3 connector as headers | | ||
| | sqlpp23::sqlite3_module | import sqlpp23::sqlite3; | The SQLite3 connector as a module | | ||
|
|
||
| [^1]: The SQLCipher connector re-uses the codebase of the SQLite3 connector. |
Owner
There was a problem hiding this comment.
foot notes 1 and 2 seem to be swapped?
Contributor
Author
There was a problem hiding this comment.
Indeed I somehow missed that! That should be fixed now.
…scriptions of the module targets.
MeanSquaredError
force-pushed
the
fix_module_install_4
branch
from
11b4326 to
689a03f
Compare
Owner
|
Thanks for the changes, LGTM! |
Contributor
Author
|
Great! That concludes pretty much all the changes related to modules, that I had in mind. So right now sqlpp23 is one of the few libraries that fully support modules (modulo any bugs that the recent changes may have introduced :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports the CMake module targets and documents them. I built and tested it with
(all connectors included, modules disabled)
and
(all connectors included, modules enabled)
So hopefully it doesn't break anything.
The test targets could be renamed or aliased as well to make their names more in-line with the names of the module targets, but that's not urgent and can wait until someone finds the time to do that :-)