overlays: Ensure that defined pin groups are used #7158
Merged
+158
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the whitespace before making any other changes. Signed-off-by: Phil Elwell <[email protected]>
Contributor
Author
|
raspberrypi/utils#155 is the corresponding change to overlaycheck that requires this PR to be merged first. |
In order to prevent confusing problems where pin configuration is not be applied, an upcoming change to the overlaycheck utility will add a check that all added pin groups are in some way referenced by the overlay. Before that can be done, it is necessary to ensure that all existing overlays pass that test. This patch modifies some overlays by adding the required "pinctrl-0" properties, but for others that are just setting GPIOs to inputs and outputs, where those same GPIOs are declared by <name>-gpios properties, it is better to drop the pin groups and let the GPIO subsystem set up the GPIOs as required. Removing this duplication may be helpful in the future should we ever decide to enable the exclusive GPIO vs pinctrl locking (.strict in struct pinmux_ops). See: https://forums.raspberrypi.com/viewtopic.php?t=393742 Signed-off-by: Phil Elwell <[email protected]>
pelwell
force-pushed
the
overlaypinctrl
branch
from
2aa2d89 to
8f58476
Compare
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 2, 2025
kernel: configs: Add CONFIG_INPUT_PWM_BEEPER=m See: raspberrypi/linux#7154 kernel: Correcting GT928 GPIO configuration for CFA050-PI-M touchscreen See: raspberrypi/linux#7152 kernel: overlays: Ensure that defined pin groups are used See: raspberrypi/linux#7158
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Dec 2, 2025
kernel: configs: Add CONFIG_INPUT_PWM_BEEPER=m See: raspberrypi/linux#7154 kernel: Correcting GT928 GPIO configuration for CFA050-PI-M touchscreen See: raspberrypi/linux#7152 kernel: overlays: Ensure that defined pin groups are used See: raspberrypi/linux#7158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent confusing problems where pin configuration is not
be applied, an upcoming change to the overlaycheck utility will add a
check that all added pin groups are in some way referenced by the
overlay. Before that can be done, it is necessary to ensure that all
existing overlays pass that test.
This patch modifies some overlays by adding the required "pinctrl-0"
properties, but for others that are just setting GPIOs to inputs and
outputs, where those same GPIOs are declared by -gpios properties,
it is better to drop the pin groups and let the GPIO subsystem set up
the GPIOs as required. Removing this duplication may be helpful in the
future should we ever decide to enable the exclusive GPIO vs pinctrl
locking (.strict in struct pinmux_ops).
See: https://forums.raspberrypi.com/viewtopic.php?t=393742