Skip to content

Add uint8 support for quantized conv2d NHWC and enable per_tensor_out operator#18279

Open
khazaei wants to merge 1 commit intopytorch:mainfrom
khazaei:export-D97036131
Open

Add uint8 support for quantized conv2d NHWC and enable per_tensor_out operator#18279
khazaei wants to merge 1 commit intopytorch:mainfrom
khazaei:export-D97036131

Conversation

@khazaei
Copy link
Contributor

@khazaei khazaei commented Mar 18, 2026

Summary:
Goal is to get the fallback path working first then add ties. Before this change the tests were not passing.

Added support for uint8 (UWORD8) data type in quantized_conv2d_nhwc_out for both standard and depthwise convolutions on HiFi backends. This change:

  • Extends op_quantized_conv2d_nhwc_out.cpp with uint8 handling for conv2d and depthwise conv2d operations using xa_nn_conv2d_per_chan_sym8sxasym8s and xa_nn_conv2d_depthwise_asym8uxasym8u kernels
  • Enables the cadence::quantized_conv2d_nhwc.per_tensor_out operator mapping in operator_fallback.bzl for both HiFi and TIE backends
  • Updates BUCK dependencies for TIE operators to include required exec_aten and kernel_runtime_context libs
  • Modifies test configuration to run on Artemis_HiFi4_UT_v3 backend
  • Fixed out_data_format for NHWC (was using NCHW format 1, should be 0)
  • Added weight transpose for depthwise conv (NHWC weight [OC,KH,KW,1] → nnlib expected [KH,KW,OC])

Differential Revision: D97036131

… operator

Summary:
Goal is to get the fallback path working first then add ties. Before this change the tests were not passing.

Added support for uint8 (UWORD8) data type in quantized_conv2d_nhwc_out for both standard and depthwise convolutions on HiFi backends. This change:
- Extends op_quantized_conv2d_nhwc_out.cpp with uint8 handling for conv2d and depthwise conv2d operations using xa_nn_conv2d_per_chan_sym8sxasym8s and xa_nn_conv2d_depthwise_asym8uxasym8u kernels
- Enables the cadence::quantized_conv2d_nhwc.per_tensor_out operator mapping in operator_fallback.bzl for both HiFi and TIE backends
- Updates BUCK dependencies for TIE operators to include required exec_aten and kernel_runtime_context libs
- Modifies test configuration to run on Artemis_HiFi4_UT_v3 backend
- Fixed out_data_format for NHWC (was using NCHW format 1, should be 0)
- Added weight transpose for depthwise conv (NHWC weight [OC,KH,KW,1] → nnlib expected [KH,KW,OC])

Differential Revision: D97036131
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 18, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18279

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Awaiting Approval, 1 Cancelled Job, 2 Unrelated Failures

As of commit ed52ef6 with merge base 3604d3e (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 18, 2026

@khazaei has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97036131.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant