Update permute removal pass to handle binary operations, and cleanup better#18256
Open
mcremon-meta wants to merge 4 commits intomainfrom
Open
Update permute removal pass to handle binary operations, and cleanup better#18256mcremon-meta wants to merge 4 commits intomainfrom
mcremon-meta wants to merge 4 commits intomainfrom
Conversation
Summary: As titled. Useful especially for resnet backbones, to reduce quant/dequant pressure. Reviewed By: DrJessop Differential Revision: D96683989
Summary: As titled. Should perform better and also allow removing some permutes when convolutions are also moved to channel last. Reviewed By: hsharma35 Differential Revision: D96869747
Summary: As titled. Calls into nnlib directly. Reviewed By: hsharma35 Differential Revision: D96874522
…better Summary: As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases. Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture. Reviewed By: abeakkas Differential Revision: D96940254
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18256
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 6 Unrelated FailuresAs of commit ad581f1 with merge base ed57040 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96940254. |
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. It is currently not cleaning up as much as it should, and the pass is only capable of handling single input cases.
Result: from 9 to 1 (minimum by construction) permutes on Wake Gesture.
Reviewed By: abeakkas
Differential Revision: D96940254