bisect: Allow sequences without __len__ when hi is explicitly provided#15493
Merged
srittau merged 1 commit intopython:mainfrom Mar 7, 2026
Merged
bisect: Allow sequences without __len__ when hi is explicitly provided#15493srittau merged 1 commit intopython:mainfrom
hi is explicitly provided#15493srittau merged 1 commit intopython:mainfrom
Conversation
CPython's `bisect` does not evaluate `len(a)` if `hi` is explicitly passed. This commit adds `SupportsGetItem` overloads to reflect this runtime behavior.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15492
Currently, the
bisectmodule stubs strictly require the first argumentato implement__len__(viaSupportsLenAndGetItemor similar sequence protocols). However, in the CPython source code,len(a)is never evaluated if thehiparameter is explicitly provided.This causes false-positive type errors when users pass custom lazy-evaluated sequences, database cursors, or virtual arrays that only support
__getitem__, even when they properly define the upper boundhi.This PR fixes this by introducing new overloads that fall back to
SupportsGetItem[int, T]whenhi: intis specified.