Skip to content

Remove unnecessary isinstances #20670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 1 commit into from
Jan 28, 2026
+0 −6
Merged

Remove unnecessary isinstances #20670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions mypyc/analysis/ircheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,6 @@ def visit_load_literal(self, op: LoadLiteral) -> None:
expected_type = "builtins.str"
elif isinstance(op.value, bytes):
expected_type = "builtins.bytes"
elif isinstance(op.value, bool):
expected_type = "builtins.object"
elif isinstance(op.value, float):
expected_type = "builtins.float"
elif isinstance(op.value, complex):
Expand Down
4 changes: 0 additions & 4 deletions mypyc/test/test_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ def assert_blobs_same(x: Any, y: Any, trail: tuple[Any, ...]) -> None:
for (xk, xv), (yk, yv) in zip(x.items(), y.items()):
assert_blobs_same(xk, yk, trail + ("keys",))
assert_blobs_same(xv, yv, trail + (xk,))
elif isinstance(x, dict):
assert x.keys() == y.keys(), f"Keys mismatch at {trail}"
for k in x.keys():
assert_blobs_same(x[k], y[k], trail + (k,))
elif isinstance(x, Iterable) and not isinstance(x, (str, set)):
# Special case iterables to generate better assert error messages.
# We can't use this for sets since the ordering is unpredictable,
Expand Down