[mypyc] Fix crash on multiple nested decorated functions with same name #20666
+107
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Jan 28, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for the fix, one suggestion about another case to test.
| async def wrapper(*args, **kwargs) -> Any: | ||
| return get_multiplier() * await fn(*args, **kwargs) | ||
| else: | ||
| @functools.wraps(fn) |
Collaborator
There was a problem hiding this comment.
Can you also test this without using @functools_wraps? It might behave differently.
Collaborator
Author
There was a problem hiding this comment.
good call, turns out the fix wasn't right for all cases so i have updated it and added another test.
Collaborator
There was a problem hiding this comment.
Some more test case ideas, since this area seems to be have bugs: can you also test cases where none of the conditional variants are decorated, or some of variants are decorated (all of these could include sync + a mix of async/sync functions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when a nested function has different definitions in different condition branches. mypyc currently crashes in this case when calling
get_func_targetintransform_decoratorhttps://github.com/python/mypy/blob/master/mypyc/irbuild/function.py#L118.The
FuncDefobjects for the definitions after the first one will have theoriginal_defattribute set. This makesget_func_targetlookup this original def but it doesn't find it when the original def is a decorator because registers are only created forFuncDefs.Extracting a
FuncDeffrom the original decorator and looking it up instead fixes the crash.