gh-145846: Fix memory leak in _lsprof clearEntries() context chain#145847
Open
raminfp wants to merge 4 commits intopython:mainfrom
Open
gh-145846: Fix memory leak in _lsprof clearEntries() context chain#145847raminfp wants to merge 4 commits intopython:mainfrom
raminfp wants to merge 4 commits intopython:mainfrom
Conversation
clearEntries() only freed the top currentProfilerContext but did not walk the previous linked list. When clear() is called during active profiling with nested calls, all contexts except the top one were leaked. Fix by iterating the entire linked list, matching the existing freelistProfilerContext cleanup pattern.
vstinner
approved these changes
Mar 27, 2026
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I confirm that ./python -m test test_profiling.test_tracing_profiler -m test_clear_with_nested_calls -R 3:3 leaks without the fix, and doesn't leak with the fix.
- Rename 'c' to 'pContext' in clearEntries() loop for consistency - Rename 'p' to 'profiler' in test_clear_with_nested_calls()
Contributor
Author
|
@vstinner Thanks for review, done! |
Member
|
"Tests / All required checks pass" fails with: Let me try to [Update branch] to see if it repairs the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
clearEntries()to walk the entirecurrentProfilerContextlinked list instead of only freeing the top context, preventing memory leaks whenclear()is called during nested profiled calls._lsprof: Memory leak inclearEntries()context chain not fully freed #145846