-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-142737: Handle lost io.open in _Py_FindSourceFile
#142747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ZeroIntensity
merged 19 commits into
python:main
from
johnslavik:check-callable-callmethodformat
Dec 15, 2025
+35
−1
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cf8b9c3
Check `callable` isn't `NULL` in `_PyObject_CallMethodFormat`
johnslavik 1cb2a7e
Add initial test idea
johnslavik e5c77a0
Give test cases meaningful names
johnslavik 173fd5c
Skip tests that require lines to be captured
johnslavik 6b81561
Add news entry
johnslavik 323385d
Goto `error` immediately if we can't get handle to `io.open`
johnslavik 092356b
Clarify skip reason
johnslavik 1a971f4
Add some docs & comments to tests
johnslavik 206633c
Elaborate in the news entry
johnslavik d95a3d4
Use a subprocess-based test
johnslavik 36a91ad
Examine `rc` to make sure it's not a crash
johnslavik b3d1296
Simplify minimal reproducer
johnslavik e0933bb
Fiat lux
johnslavik 6589e9f
Fix formatting
johnslavik bea29ea
Apply suggestion from @johnslavik
johnslavik 77effbc
Apply suggestion from @johnslavik
johnslavik 45774d2
Add `assert(callable != NULL)` in `_PyObject_CallMethodFormat`
johnslavik ae292f5
Mark as CPython-only and mention `_Py_FindSourceFile`
johnslavik f9aae29
Better wording in the comment
johnslavik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Core_and_Builtins/2025-12-15-15-01-21.gh-issue-142737.xYXzeB.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Tracebacks will be displayed in fallback mode even if :func:`io.open` is lost. | ||
| Previously, this would crash the interpreter. | ||
| Patch by Bartosz Sławecki. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.