-
-
Notifications
You must be signed in to change notification settings - Fork 34k
gh-142417: Add PyInitConfig_SetInitCallback() function #142420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vstinner
wants to merge
3
commits into
python:main
Choose a base branch
from
vstinner:init_callback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+186
−12
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -238,6 +238,43 @@ Module | |
| Similar to the :c:func:`PyImport_AppendInittab` function. | ||
|
|
||
|
|
||
| Initialization Callback | ||
| ----------------------- | ||
|
|
||
| .. c:function:: int PyInitConfig_SetInitCallback(PyInitConfig *config, PyStatus (*callback)(void *arg), void *arg) | ||
|
|
||
| Set an initialization callback. It allows executing code as soon as the | ||
| Python interpreter is initialized, before the first import. For example, it | ||
| can be used to add a meta path importer into :data:`sys.meta_path`. | ||
|
|
||
| When the callback is called, Python is only partially initialized. What's | ||
| available at this point: | ||
|
|
||
| * Builtin types; | ||
| * Builtin exceptions; | ||
| * Builtin and frozen modules (can be imported); | ||
| * The :mod:`sys` module is only partially initialized | ||
| (ex: :data:`sys.path` and :data:`sys.stdout` don't exist yet). | ||
|
|
||
| After the callback, the Python initialization is completed: | ||
|
|
||
| * Install and configure :mod:`importlib`; | ||
| * Apply the :ref:`Path Configuration <init-path-config>`; | ||
| * Install signal handlers; | ||
| * Finish :mod:`sys` module initialization (ex: create :data:`sys.stdout` | ||
| and :data:`sys.path`); | ||
| * Enable optional features like :mod:`faulthandler` and :mod:`tracemalloc`; | ||
| * Import the :mod:`site` module; | ||
| * etc. | ||
|
|
||
| A single callback can be registered. If this function is called more than | ||
| once, the previous callback is overridden. | ||
|
Comment on lines
+270
to
+271
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably start out by returning an error in this case. This is useful for embedding, it feels like multiple calls is always a bug until someone can make an argument otherwise. |
||
|
|
||
| * Return ``0`` on success. | ||
| * Set an error in *config* and return ``-1`` on error. | ||
|
|
||
| .. versionadded:: next | ||
|
|
||
| Initialize Python | ||
| ----------------- | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/C_API/2025-12-08-16-12-34.gh-issue-142417.tYamiX.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Add :c:func:`PyInitConfig_SetInitCallback` to execute code as soon as the | ||
| Python interpreter is initialized, before the first import. For example, it can | ||
| be used to add a meta path importer into :data:`sys.meta_path`. Patch by Victor | ||
| Stinner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"executing code as soon as the Python interpreter is initialized"
vs
"Python is only partially initialized. What's available ...:"
two different values of "initialized" here. That's a small list of what is available. Should we bother allowing people to call into Python at all or calling equivalent C Python C APIs from such an API? it feels maybe vaguely defined and hard to support and like something we might change the hyrum's law shape of what is available here?