Allow 1 mode images in MorphOp #9348
Open
+23
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pillow/src/PIL/ImageMorph.py
Lines 234 to 241 in ca21683
I expect 'a binary image' to mean a 1 mode image, not an L mode image. Considering the nature of
get_on_pixels(), looking for pixels that are non-zero, I think the original intention was for this to be used with 1 mode images, and accepting L mode images was a misunderstanding.#691
But I expect that we don't want to remove long-established functionality, so this PR allows for both 1 and L mode images.
I've also added this functionality to
apply()andmatch().