UV + Precommit + a CLI Entry Point#110
Open
dvankampen wants to merge 5 commits intopython-jsonschema:masterfrom
Open
UV + Precommit + a CLI Entry Point#110dvankampen wants to merge 5 commits intopython-jsonschema:masterfrom
dvankampen wants to merge 5 commits intopython-jsonschema:masterfrom
Conversation
… line interface. added a test for said interface as well
for more information, see https://pre-commit.ci
Member
|
Thanks Dave! I'm really looking forward to getting this out to our users 😁 After we talked at the sprints; I think my suggestion is to split this up into a sequence of PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is a bit conflated as it introduces a handful of things. I am of course open to discussing splitting it up however we see fit.
hypothesisjson)The work is not yet quite complete, but it is mature enough to need some input. For instance:
seedandnumarguments detailed on New feature: command-line interface #106 ?example()? Right now it raises anonInteractiveWarning, so I think not. Open to suggestions on generation otherwise.