Test free-threaded Python with pytest-run-parallel #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
pytest-run-parallel
branch
from
f90fbfa to
699ed8b
Compare
ngoldbaum
requested changes
Nov 19, 2025
Contributor
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
Passing --iterations like this makes the tests for everyone run at least 8 times slower.
Rather than editing the global tox config, I'd rather see one test job set up to run with --parallel-threads=auto and not use --iterations.
I'd rather see more attention being paid to writing multithreaded tests that use a shared Compressor and Decompressor. Maybe take a look at google/brotli#1386 for inspiration.
By the way, for all this free-threaded support stuff, I'm very happy to do all the work rather than reviewing it. You'll just have to be a little more patient with me.
Contributor
|
I'm going to abort the test run here because it's still going after 1 hour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be confident about free-threaded compatibility, it is recommended to test with
pytest-run-parallel.Something like:
%
uvx --with=pytest-run-parallel pytest --iterations=8 --parallel-threads=auto