Support overrides in annotated attributes #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinche
force-pushed
the
tin/overrides-in-annotated
branch
from
85bd2e8 to
ad643c7
Compare
hynek
reviewed
Jan 27, 2026
| One of the fundamental [design decisions](why.md#design-decisions) of _cattrs_ is that serialization rules should be separate from the models themselves; | ||
| by using this feature you're going against the spirit of this design decision. | ||
|
|
||
| However, software is written in many different context and with different constraints; and practicality (sometimes) beats purity. |
Member
There was a problem hiding this comment.
Suggested change
| However, software is written in many different context and with different constraints; and practicality (sometimes) beats purity. | |
| However, software is written in many different context and with different constraints; and practicality _sometimes_ beats purity. | |
| _Sometimes_, it's not worth introducing a mapping layer to rename one field. | |
| _Sometimes_, you're busy prototyping and will clean up your code later. | |
| The danger is not any single compromise, but their accumulation. | |
| One of the most important skills as a software engineer is knowing when the cost of a trade-off has crossed the line and it's time to do things properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.