Skip to content

Conversation

@gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Jan 29, 2026

Since the create generic can now handle everything upload use to do, moving everything over and deprecating upload.

@@ -0,0 +1 @@
Deprecated `pulp python content upload` command. Use `pulp python content create` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not the other way around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a create generic and not an upload generic. But I'm open to either, they both ultimately call the same code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the generic and overwrite it's name?
I think "upload" is the more intuitive when you have a file on disk. ... oh hold on. Create can also accept a url to down load, right? In fact "create" even is the more generic name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, in the PulpContentContext the upload function is deprecated according to the comment and it says to use the create call, so just reusing same logic for the commands.

@gerrod3 gerrod3 merged commit dae5f7a into pulp:main Jan 30, 2026
18 checks passed
@gerrod3 gerrod3 deleted the pyt-con-rep branch January 30, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants