include perf boost as well as ECMA6 detect for include or contains#105
Open
jwestbrook wants to merge 1 commit intoprototypejs:masterfrom
Open
include perf boost as well as ECMA6 detect for include or contains#105jwestbrook wants to merge 1 commit intoprototypejs:masterfrom
jwestbrook wants to merge 1 commit intoprototypejs:masterfrom
Conversation
Collaborator
Author
|
@savetheclocktower Any possibility of getting this PR merged in? |
codemasher
added a commit
to codemasher/prototype
that referenced
this pull request
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the proposed polyfill for ECMA6 for
String.prototype.contains()http://wiki.ecmascript.org/doku.php?id=harmony:string_extras
using not equivalent to
!==instead of greater than>gets a performance boost according tohttp://jsperf.com/string-contains
as well as add the detection if
String.prototype.contains()exists then mapinclude()to that