Publish org.processing.core.pdf to maven Central#1407
Publish org.processing.core.pdf to maven Central#1407catilac merged 1 commit intoprocessing:mainfrom
org.processing.core.pdf to maven Central#1407Conversation
|
@Stefterv hey started with PDF since it was the easiest. |
org.processing.core.pdf to maven Central
|
Thanks @avinxshKD I added a few comments ;) |
sure was already on it thanks and welcome :) |
dd75209 to
c8b553d
Compare
|
@Stefterv Updated the coordinates and removed the signing checkk. and |
|
Ready for another look. |
|
The coordinates still need to be fixed, the version should be equal to the processing version, not the version from the library.properties |
c8b553d to
714f11e
Compare
|
@Stefterv hve updated the version to use rootProject.version so it matches the Processing version as requested |
|
Hi @avinxshKD, it appears to me that you are overly relying on AI for making your changes, please take a look at the "General note about github comments, reviews, and PRs" section of this message. |
dbf8486 to
6772f84
Compare
|
@Stefterv so sorry. Been swamped with exams lately,will be more careful reviewing before pushing. |
|
No worries @avinxshKD thank you for the changes they look great 💙 |
Hi @avinxshKD! Just popping in to say, in general everything is pretty low-stakes. So there isn't any intense pressure. This can be a space to take it easy. Though, we really appreciate all the effort you've been making! And if you ever have questions, always feel free to discuss in the PR or in the discord with the others :) Hope your exams aren't too stressful! Okay popping out 🍿 |
|
thanks @catilac, really appreciate ur kind words Dont know much about discord tho, but i will try fs <3 Yup see you around, thanks again for chcking in... means alot |
|
@avinxshKD would you be able to rebase your branches onto main? We've fixed up some of the build shenanigins and I would like to see your checks passing before merging. Please let me know if you have any questions about rebasing, and I'll be happy to help! |
6772f84 to
236ee65
Compare
Adds Maven Central publishing configuration to the PDF library.
Part of #1403