Skip to content

fix(dom): remove leftover console.log(id) from removeCue (#8609)#8614

Closed
gourijain029-del wants to merge 1 commit intoprocessing:mainfrom
gourijain029-del:fix-8609-removecue-console-leak
Closed

fix(dom): remove leftover console.log(id) from removeCue (#8609)#8614
gourijain029-del wants to merge 1 commit intoprocessing:mainfrom
gourijain029-del:fix-8609-removecue-console-leak

Conversation

@gourijain029-del
Copy link

@gourijain029-del gourijain029-del commented Mar 5, 2026

1. Changes made

Removed an accidental/leftover console.log(id); debug statement from the removeCue(id) method on p5.MediaElement in src/dom/dom.js. This prevents internal cue IDs from unexpectedly leaking into the user's browser console every time a cue is removed.

2. Which issue this PR fixes

Fixes #8609

3. Steps to test changes

  • Set up a sketch that creates an audio/video element (e.g. createAudio()).
  • Add a cue using .addCue().
  • Programmatically remove that cue using .removeCue().
  • Verify the browser console remains clean and no longer redundantly logs the cue's ID number.

@ksen0
Copy link
Member

ksen0 commented Mar 9, 2026

Hello! Please read carefully & follow contributor guidelines in the future. PRs made on issues that are no approved and assigned may be closed. This is o reduce duplicate work. In this case, someone else was already working on it, so I will close this. Thanks for understanding!

@ksen0 ksen0 closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[p5.js 2.0 Bug Report]: removeCue() on p5.MediaElement leaks debug console.log(id) to user console

2 participants