Migrated from JSHint to ESLint#3836
Migrated from JSHint to ESLint#3836Nishthajain7 wants to merge 1 commit intoprocessing:develop-codemirror-v6from
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
Hi! Thank you so much for the contribution! If this is regarding the codemirror 5 to 6 migration, the subissue we published was actually regarding the js linter used within the Editor/stateUtils.js file. I do think the approach is correct, it would be great if you could move the changes to that file! |
5006ef4 to
8955370
Compare
|
Sorry for the delay. There were a lot of emails, and this one slipped through. I've moved the changes to |
|
Hi Nishthajain7! I checked out the branch and it doesn't build properly -- it looks like |
| import { xml } from '@codemirror/lang-xml'; | ||
| import { linter } from '@codemirror/lint'; | ||
| import { JSHINT } from 'jshint'; | ||
| import { Linter } from 'eslint-linter-browserify'; |
There was a problem hiding this comment.
maybe we can import this as import {Linter as ESLint} to keep the naming clear?
Fixes #1540
Changes: Updated the preprocessing lint step to use ESLint instead of JSHint.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123