Convert tidier.js to TypeScript and add CodeMirror view typings#3823
Convert tidier.js to TypeScript and add CodeMirror view typings#3823VaibhavNarayann wants to merge 0 commit intoprocessing:develop-codemirror-v6from
Conversation
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-21672378de |
2f63910 to
97f761d
Compare
|
I'm not exactly sure how, but the diff looks a little bit crazy right now : O I glanced at the PR a week ago and the few changes seemed fine, but now I see a much larger diff, I assume because of some rebasing or pulling from develop? I've had this happen before and couldn't figure out how to fix it other than opening a new branch and cherrypicking my changes over... is there any way to do something similar here? |
|
hey @khanniie, it definitely looks like some extra history got pulled in during a merge or rebase. the best way to solve this and much faster than cherry-picking to a new branch is a soft reset. @VaibhavNarayann, if you run |
78ad83a to
963c02d
Compare
Fixes #3815
Summary
This PR converts the existing
tidier.jsmodule to TypeScript and adds explicittypings while preserving the current formatting behavior.
Changes
tidier.js→tidier.tsEditorViewjavascript | html | css)formatWithCursorVerification
Manually verified that Tidy / Format works correctly for:
The editor cursor remains stable after formatting and does not jump unexpectedly.
Checklist
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)Fixes #3815)