Merged
Conversation
🦋 Changeset detectedLatest commit: 8f67fd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an accessibility audit issue by replacing <Text> components with <Heading as="h2"> components for sidebar section headings in the PageHeader examples. This ensures proper semantic HTML structure, rendering these labels as <h2> elements instead of <span> elements, which improves screen reader support and maintains proper heading hierarchy.
Changes:
- Updated "Assignees" and "Labels" section headings in the
WithPageLayoutstory to use semantic<Heading as="h2">elements instead of<Text>elements
llastflowers
added
the
integration-tests: skipped manually
Contributor
Author
|
integration tests skipped manually: storybook-only changes in this PR |
llastflowers
deleted the
llastflowers/14987/PageHeader-story-semantic-heading-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/github/accessibility-audits/issues/14987
Changelog
Changed
Change
<Text>to<Heading>so that element is rendered ash2instead ofspan.Before / After:
Rollout strategy
Testing & Reviewing
Merge checklist