Skip to content

WIP: Fix UnderlineNav CLS by using wrapping to overflow items onto the next (hidden) line#7505

Draft
iansan5653 wants to merge 2 commits intotylerjdev/overflow-underlinenavfrom
underline-nav-overflow-ssr-spike
Draft

WIP: Fix UnderlineNav CLS by using wrapping to overflow items onto the next (hidden) line#7505
iansan5653 wants to merge 2 commits intotylerjdev/overflow-underlinenavfrom
underline-nav-overflow-ssr-spike

Conversation

@iansan5653
Copy link
Contributor

This is just a quick proof of concept to show a CSS-based approach to hiding overflowing items. It uses flex-wrap to wrap them onto the next line, along with overflow: hidden and an explicit height to clip subsequent lines.

In addition, this shows how we can use CSS scroll-state container queries to determine whether or not to show the tab icons and overflow menu initially.

This is a minimal and quick PR - after the initial render, all the logic is still done by JS-based width calculations.

For more context, see https://github.com/github/primer/issues/6291#issuecomment-3861950186

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

⚠️ No Changeset found

Latest commit: 1835cfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot requested a deployment to storybook-preview-7505 February 6, 2026 20:33 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-7505 February 6, 2026 20:45 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant