ORTB config for ad unit level #916
Open
+234
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanylov-sigma
requested review from
ValentinPostindustria and
YuriyVelichkoPI
and removed request for
ValentinPostindustria and
YuriyVelichkoPI
mdanylov-sigma
force-pushed
the
feature/1194-ad-slot-targeting
branch
from
e8d1ab7 to
b6f99fd
Compare
mdanylov-sigma
requested review from
ValentinPostindustria and
YuriyVelichkoPI
ValentinPostindustria
requested changes
Dec 11, 2025
| adUnitConfiguration.setImpOrtbConfig(ortbConfig); | ||
| } | ||
|
|
||
| @Nullable |
Collaborator
There was a problem hiding this comment.
PrebidDisplayView is used only as an internal class. So we don't need to pass the global config params to it. setImpOrtbConfig can also be removed.
| /** | ||
| * Sets the global OpenRTB configuration string for the ad unit. It takes precedence over `Targeting.setGlobalOrtbConfig`. | ||
| * Expected format: {@code "{"new_field": "value"}"}. | ||
| * @param ortbConfig The global OpenRTB JSON configuration string to set. Can be `nil` to clear the configuration. |
Collaborator
There was a problem hiding this comment.
Refactor nil to null in all setGlobalOrtbConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns with iOS implementation, more details in the #1194