Open
Conversation
rschristian
reviewed
Jun 29, 2020
| --devServer Determine if dev server should be enabled (default true) | ||
| --dest Specify output directory if dev server is disabled (default build) | ||
| --ignore Path relative to src to be ignored during watch if dev server is disabled | ||
| --esm Builds ES-2015 bundles for your code. (default true) |
Member
There was a problem hiding this comment.
nitpick: The slightly different indentation here is quite noticeable on the rendered file
rschristian
reviewed
Jun 29, 2020
| .option( | ||
| '--ignore', | ||
| 'Path relative to src to be ignored during watch if dev server is disabled', | ||
| '' |
Member
There was a problem hiding this comment.
This default value means that src/ is ignored by default. I don't think this is intended?
Member
|
A user will be unable to use even simple stylesheet imports without wrapping in a window check with this system. Can we possibly improve the developer experience and find a way to make this work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
No
Summary
#1248
Does this PR introduce a breaking change?
No