make-xges: Perform a simplistic conversion of text annotations#9
Open
jhenstridge wants to merge 2 commits intomasterfrom
Open
make-xges: Perform a simplistic conversion of text annotations#9jhenstridge wants to merge 2 commits intomasterfrom
jhenstridge wants to merge 2 commits intomasterfrom
Conversation
jhenstridge
force-pushed
the
text-annotations
branch
from
13ef84a to
f040252
Compare
|
Proper text rendering could be don with pango. I'm working on that. Unfortunately, my fork already diverged too much to make a PR feasible :/ |
|
Chuck it in a repo so we can compare them. It might not be that bad.
…On Sat, 17 Apr 2021, 00:03 Marcel Hellkamp, ***@***.***> wrote:
Proper text rendering could be don with pango. I'm working on that.
Unfortunately, my fork already diverged too much to make a PR feasible :/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKONLBJ2GCH3XPQMCAB6J3TJBNUZANCNFSM42QUYGOQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a first attempt to get text annotations working. It is enough to get @symptog's presentation to render the text (at about the 50 second mark):
annotations-test2.mp4
... however it has some limitations. Namely it will not wrap long lines to fit the bounding box of the original HTML text. The positioning is not quite the same either, since the SVG text is positioned by the baseline rather than top left of bounding box.
I needed to convert the
colorCSS property tofillfor colour to be applied. It's possible some other properties might need adjusting too.