Check incompatible operand values for greater/smaller operands#217
Open
kamil-zacek wants to merge 13 commits intophpstan:1.5.xfrom
Open
Check incompatible operand values for greater/smaller operands#217kamil-zacek wants to merge 13 commits intophpstan:1.5.xfrom
kamil-zacek wants to merge 13 commits intophpstan:1.5.xfrom
Conversation
…orted by PHPStan core
…r and description for logical operators
kamil-zacek
force-pushed
the
unsupported-value-lt-gt
branch
9 times, most recently
from
81ae0c3 to
7b569cc
Compare
…an value for greater / smaller comparison is not allowed).
kamil-zacek
force-pushed
the
unsupported-value-lt-gt
branch
from
7b569cc to
47a3db0
Compare
|
Here is a more generic approach: https://github.com/shipmonk-rnd/phpstan-rules#allowcomparingonlycomparabletypes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.